Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded app support for SkeletonPage #202

Closed
rkbhochalya opened this issue Oct 17, 2017 · 2 comments
Closed

Embedded app support for SkeletonPage #202

rkbhochalya opened this issue Oct 17, 2017 · 2 comments

Comments

@rkbhochalya
Copy link

Issue summary

If you use SkeletonPage in an embedded app it shows the loading version of the page title and secondary actions below the app bar.

Expected behavior

SkeletonPage should not show the loading version of the page title and secondary actions when used in embedded apps. The value for title and actions in the bar can be discussed.

Actual behavior

SkeletonPage when used in an embedded app, shows the loading version of the page title and secondary actions below the app bar.

Steps to Reproduce the Problem

  1. Use SkeletonPage in an embedded app.

Specifications

  • Polaris version: 1.7.0
  • React version: 15.6.1
@dleroux
Copy link
Contributor

dleroux commented Oct 18, 2017

Thanks @rkbhochalya for pointing out this issue. A fix is currently under review in a internal repo.

@dleroux
Copy link
Contributor

dleroux commented Oct 24, 2017

@rkbhochalya closing this as it is now fixed in the latest 1.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants