Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New DL] Color picker alpha checkers are invisible #3789

Closed
dostu opened this issue Jan 7, 2021 · 2 comments
Closed

[New DL] Color picker alpha checkers are invisible #3789

dostu opened this issue Jan 7, 2021 · 2 comments
Labels
Bug Something is broken and not working as intended in the system. no-issue-activity untriaged

Comments

@dostu
Copy link

dostu commented Jan 7, 2021

Issue summary

When new design language is enabled color picker checkers background is not visible when it is is on white background (i.e. in Card).

I believe the issue was introduced here: #2768

background-image: linear-gradient(45deg, var(--p-surface, #dfe3e8) 25%, transparent 25%), linear-gradient(-45deg, var(--p-surface, #dfe3e8) 25%, transparent 25%), linear-gradient(45deg, transparent 75%, var(--p-surface, #dfe3e8) 75%), linear-gradient(-45deg, transparent 75%, var(--p-surface, #dfe3e8) 75%);

--p-surface value is white, so checkers are invisible on white background.

Expected behavior

Checkers should be visible.

Screenshot 2021-01-07 at 18 40 26

Actual behavior

They are not.

Screenshot 2021-01-07 at 18 38 52

Steps to reproduce the problem

  1. Enable new design language (<AppProvider features={{ newDesignLanguage: true }}>)
  2. Add color picker with alpha value (<ColorPicker allowAlpha />) on white background.

Reduced test case

https://codesandbox.io/s/shopify-polaris-react-colorpicker-checkers-example-8bxor

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: 5.12.0
  • Browser: Chrome (Version 87)
  • Device: MacBook Pro
  • Operating System: macOS 10.15.6
@dostu dostu added the Bug Something is broken and not working as intended in the system. label Jan 7, 2021
@ghost
Copy link

ghost commented Jan 7, 2021

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's design system and dev experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. no-issue-activity untriaged
Projects
None yet
Development

No branches or pull requests

3 participants