Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character limit component #986

Closed
elliejeon opened this issue Feb 7, 2019 · 4 comments · Fixed by #992
Closed

Character limit component #986

elliejeon opened this issue Feb 7, 2019 · 4 comments · Fixed by #992
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@elliejeon
Copy link

elliejeon commented Feb 7, 2019

Issue summary

Character counter breaks the text field when the input text gets longer than the provided space and makes the scroll bar appears.

Expected behavior

Scroll bar should stick to the right side of the text field and allow the entire space inside the field to be used for text input.

Actual behavior

Scroll bar appears in the middle of the field, left to the character counter.
User is also given limited space to input text, left to the invisible column which character counter takes up.
It is also taking up a lot of space, especially when the field width is narrow.

This is related to this issue: #709

Steps to reproduce the problem

character count

@emarchak @dpersing @TheEnzoMar

@ghost
Copy link

ghost commented Feb 7, 2019

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

@emarchak
Copy link
Contributor

emarchak commented Feb 7, 2019

On multiline fields overlaying the counter would cause the text to show under the element if it takes the entire space of the field. On this initial look, I could see three options:

  1. Accept the overlayed text weirdness that comes with a fixed height + text counter
  2. Expand the component to allow the full text to be shown without scroll, thereby avoiding this.
  3. Stop the active area (scrollbar) above the text element so that there's space to show the counter, but it would look very janky.

@sarahill do you have any thoughts on this?

@emarchak emarchak self-assigned this Feb 7, 2019
@dpersing
Copy link
Contributor

dpersing commented Feb 7, 2019

Expand the component to allow the full text to be shown without scroll, thereby avoiding this.

That's my favorite option!

@dpersing dpersing added the Bug Something is broken and not working as intended in the system. label Feb 7, 2019
@sarahill
Copy link
Contributor

@emarchak I agree with Devon. Option 2. makes the most sense to me in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants