Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxonomy mapping models and the logic to generate mappings from a list of mapping rules #121

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

chesterbot01
Copy link
Contributor

@chesterbot01 chesterbot01 commented Mar 22, 2024

Description

  • This PR introduces models for representing taxonomy mappings. MappingRule is defined as an input and output. Input and output are of Product type, which mean they are shaped like the products of the taxonomies being mapped.
  • To generate mappings from a list of MappingRules, some services are introduced:
    • InputProductGenerator is used to generate combinations for all characteristic product categories and their attributes that appear in the input.
    • MappingBuilder is a compiler then passes each input through the set of matching rules, reducing the output of each rule into a final output
  • Add from_shopify_to_google taxonomy mapping rules in YAML.

@chesterbot01 chesterbot01 changed the title Add taxonomy mapping models and the logic to generate mappings from a… Add taxonomy mapping models and the logic to generate mappings from a list of mapping rules Mar 22, 2024
@chesterbot01 chesterbot01 marked this pull request as ready for review March 22, 2024 20:40
Copy link
Collaborator

@elsom25 elsom25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, can you post a copy of the local taxonomy viewer running to validate data generation continues to work as we expect? (aka run make serve)

Exciting step!

@chesterbot01
Copy link
Contributor Author

local taxonomy viewer is running as normal:

Screen.Recording.2024-03-25.at.4.43.08.PM.mov

@chesterbot01 chesterbot01 merged commit 45610ba into main Mar 25, 2024
3 checks passed
@chesterbot01 chesterbot01 deleted the add-taxonomy-mapping-part1 branch March 25, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants