Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition for truffleruby+graalvm GFTC dev build #35

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

rwstauner
Copy link
Contributor

@rwstauner rwstauner commented Feb 12, 2024

Some releases don't include the assets we are looking for so loop through releases, sorted by date, to find the one we are looking for.

@rwstauner rwstauner force-pushed the rwstauner/truffleruby+graalvm-gftc-dev branch from 2c0d4f3 to 089cde1 Compare February 12, 2024 17:36
Copy link
Contributor

@nirvdrum nirvdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but how much work would it be to iterate through the most recent releases and find the latest one there? Also, just in case you don't know, ruby-build now supports the RUBY_BUILD_TARBALL_OVERRIDE environment variable to specify the URL for a tarball to install.

@rwstauner
Copy link
Contributor Author

In the past I've had trouble looping over releases and hitting an API limit since the requests are unauthenticated.
Could be worth trying though.

Thanks, I didn't realize there was an env var to override any ruby you're installing, that's good to know.
I was surprised I didn't see any other env vars in definitions, this would be why.
No reason to add another here.

@rwstauner rwstauner force-pushed the rwstauner/truffleruby+graalvm-gftc-dev branch from 089cde1 to 48103c4 Compare February 13, 2024 23:42
@rwstauner
Copy link
Contributor Author

rwstauner commented Feb 13, 2024

This loop seems to work.
It was probably worth doing, I suspected we might eventually need something similar for the native version (since we started seeing those other releases pop up).

@rwstauner
Copy link
Contributor Author

...and now we have an instance of them not being in the order we want, so we might need to try to sort the release names (they do contain dates) 🤔

Different releases contain different assets so attempt to loop through
the releases to find the most recent one with the desired asset.
@rwstauner rwstauner force-pushed the rwstauner/truffleruby+graalvm-gftc-dev branch from 48103c4 to a0f441c Compare February 14, 2024 17:57
@rwstauner
Copy link
Contributor Author

This now correctly finds the desired asset in the 24.0.0-dev-20240207_2228 release

@rwstauner rwstauner merged commit 44a551e into main Feb 15, 2024
3 checks passed
@rwstauner rwstauner deleted the rwstauner/truffleruby+graalvm-gftc-dev branch February 15, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants