-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definition for truffleruby+graalvm GFTC dev build #35
Conversation
2c0d4f3
to
089cde1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but how much work would it be to iterate through the most recent releases and find the latest one there? Also, just in case you don't know, ruby-build now supports the RUBY_BUILD_TARBALL_OVERRIDE
environment variable to specify the URL for a tarball to install.
In the past I've had trouble looping over releases and hitting an API limit since the requests are unauthenticated. Thanks, I didn't realize there was an env var to override any ruby you're installing, that's good to know. |
089cde1
to
48103c4
Compare
This loop seems to work. |
...and now we have an instance of them not being in the order we want, so we might need to try to sort the release names (they do contain dates) 🤔 |
Different releases contain different assets so attempt to loop through the releases to find the most recent one with the desired asset.
48103c4
to
a0f441c
Compare
This now correctly finds the desired asset in the |
Some releases don't include the assets we are looking for so loop through releases, sorted by date, to find the one we are looking for.