Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all of these to use regular requires? #1834

Closed
andyw8 opened this issue Mar 26, 2024 · 0 comments · Fixed by #1880
Closed

Update all of these to use regular requires? #1834

andyw8 opened this issue Mar 26, 2024 · 0 comments · Fixed by #1880
Assignees
@andyw8

Comments

@andyw8
Copy link
Contributor

andyw8 commented Mar 26, 2024

https://github.com/Shopify/ruby-lsp/pull/1833/files

I know it's not related to this PR, but can we please update all of these to use regular requires? The lib directory gets inserted into the $LOAD_PATH a few lines above, there's no need to use relative requires.

Originally posted by @vinistock in #1833 (comment)
@andyw8 andyw8 mentioned this issue Mar 26, 2024
Merged
@andyw8 andyw8 changed the title Update all of these to use regular requires? The lib directory gets inserted into the $LOAD_PATH a few lines above, there's no need to use relative requires. Update all of these to use regular requires? Mar 26, 2024
@andyw8 andyw8 self-assigned this Mar 26, 2024
@andyw8 andyw8 mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyw8 andyw8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid require_relative in test_helper Shopify/ruby-lsp
1 participant
@andyw8