Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OffsetManager func constructRequest() should not set offsetCommitRequestBlock.timestamp when groupInstanceId is not nil #2407

Closed
XinYu52125 opened this issue Dec 26, 2022 · 3 comments
Assignees
Labels
stale Issues and pull requests without any recent activity

Comments

@XinYu52125
Copy link

Versions

Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.

Sarama Kafka Go
1.37.2 2.4.2 1.18
Configuration

What configuration values are you using for Sarama and Kafka?

conf.Consumer.Group.InstanceId = someInstanceId
conf.Consumer.Offsets.Retention == 0 // default value
Logs
Non-zero timestamp specified for OffsetCommitRequest not v1, it will be ignored
Non-zero timestamp specified for OffsetCommitRequest not v1, it will be ignored
Problem Description

When calling func constructRequest() with conf.Consumer.Offsets.Retention == 0, OffsetCommitRequest with version 1 will be created.
After offsetCommitRequestBlock is created with perPartitionTimestamp(ReceiveTime), OffsetCommitRequest.version is changed to 7.
Thus, in func (b *offsetCommitRequestBlock) encode, the following check logic will print extra log every time.

	if version == 1 {
		pe.putInt64(b.timestamp)
	} else if b.timestamp != 0 {
		Logger.Println("Non-zero timestamp specified for OffsetCommitRequest not v1, it will be ignored")
	}
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Jul 18, 2023
@dnwe dnwe removed the stale Issues and pull requests without any recent activity label Jul 18, 2023
@dnwe dnwe self-assigned this Jul 18, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Oct 16, 2023
@dnwe dnwe removed the stale Issues and pull requests without any recent activity label Oct 16, 2023
Copy link

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the main branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Jan 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

No branches or pull requests

2 participants