removes gofork direct usage as fix is part of go #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1438 `jcmturner/gokrb5` needs to use the `jcmturner/gofork` in order to have some workarounds about some stuff not implemented or not working as expected. For the specific case of github.com/jcmturner/gofork/encoding/asn1 there is no reason right now to keep using `jcmturner/gofork` as the issue golang/go#17321 was solved/closed in Dec 15, 2016 and released in go 1.10 `jcmturner/gokrb5` still uses internally `jcmturner/gofork`, it seems the `gofork` `asn1` part could be removed and use the standar library, but that will need some more work and PRs on the `jcmturner/gokrb5` side.
|
I suspect the reason this broke things is because the fork returned its own asn1.ObjectType, which the stdlib marshalled differently, since it was not a stdlib asn1.ObjectType. To re-apply this patch, you would need to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1438
jcmturner/gokrb5needs to use thejcmturner/goforkin order to havesome workarounds about some stuff not implemented or not working as
expected.
For the specific case of github.com/jcmturner/gofork/encoding/asn1 there
is no reason right now to keep using
jcmturner/goforkas the issuegolang/go#17321 was solved/closed in Dec 15, 2016 and released in go
1.10
jcmturner/gokrb5still uses internallyjcmturner/gofork, it seemsthe
goforkasn1part could be removed and use the standar library,but that will need some more work and PRs on the
jcmturner/gokrb5side.