fix: set DescribeConfigRequest Version field #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although fbd8338 had added protocol support for DescribeConfigsRequest v1 and v2, nothing in the admin client was actually setting the Version field to utilise these. Set the Version based on the selected sarama.Config version. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This Logger modification would occasionally hit a data racein Travis:
```
WARNING: DATA RACE
Read at 0x00000130ced0 by goroutine 60:
github.com/Shopify/sarama.(*Broker).Close()
/home/travis/gopath/src/github.com/Shopify/sarama/broker.go:253 +0x4f0
github.com/Shopify/sarama.safeAsyncClose.func1()
/home/travis/gopath/src/github.com/Shopify/sarama/utils.go:52 +0xa3
github.com/Shopify/sarama.withRecover()
/home/travis/gopath/src/github.com/Shopify/sarama/utils.go:45 +0x84
Previous write at 0x00000130ced0 by goroutine 75:
github.com/Shopify/sarama.TestClusterAdminDescribeBrokerConfig()
/home/travis/gopath/src/github.com/Shopify/sarama/admin_test.go:553 +0x220
testing.tRunner()
/home/travis/.gimme/versions/go1.12.15.linux.amd64/src/testing/testing.go:865 +0x163
```
It had inadvertently been included in the test, so just remove it
mimaison
approved these changes
Jan 16, 2020
|
In the future we should use ApiVersions to automatically adjust the versions used by requests instead of relying on the user specifying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although fbd8338 had added protocol support for DescribeConfigsRequest
v1 and v2, nothing in the admin client was actually setting the Version
field to utilise these. Set the Version based on the selected
sarama.Config version.