Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): bump confluentPlatformVersion from 6.1.1 to 6.2.0 #1984

Merged
merged 5 commits into from
Sep 13, 2021
Merged

fix(test): bump confluentPlatformVersion from 6.1.1 to 6.2.0 #1984

merged 5 commits into from
Sep 13, 2021

Conversation

null-sleep
Copy link
Contributor

@null-sleep null-sleep commented Jul 12, 2021 •
edited

Part of the effort to upgrade to Kafka 2.8.0

@null-sleep null-sleep requested a review from vvuibert July 12, 2021 13:34
@null-sleep null-sleep requested a review from bai as a code owner July 12, 2021 13:34
@vvuibert vvuibert requested a review from dnwe July 21, 2021 13:15
@dnwe
Copy link
Collaborator

dnwe commented Aug 9, 2021 •
edited

@null-sleep / @vvuibert are you still working on this? I notice that the functional tests failed because it seems a kafka server side error has seemingly changed, causing the assert to fail:

2021-08-09T12:18:52.0161673Z functional_producer_test.go:104: Expected ErrUnknownTopicOrPartition, found kafka server: The request attempted to perform an operation on an invalid topic.

i.e., we’re getting ErrInvalidTopic rather than ErrUnknownTopicOrPartition

@bai
Copy link
Contributor

bai commented Sep 8, 2021

@vvuibert @null-sleep Friendly bump 🙏🏼 Do you think you'd be able to look into this test failure?

@null-sleep null-sleep force-pushed the bump-confluent-docker-image-to-6.2.0 branch from ca2b887 to ba33c76 Compare September 8, 2021 12:27
@null-sleep
Copy link
Contributor Author

I rebased off master and the tests still fail. On running make test_functional locally I get this stacktrace:

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker/api/client.py", line 214, in _retrieve_server_version
  File "docker/api/daemon.py", line 181, in version
  File "docker/utils/decorators.py", line 46, in inner
  File "docker/api/client.py", line 237, in _get
  File "requests/sessions.py", line 543, in get
  File "requests/sessions.py", line 530, in request
  File "requests/sessions.py", line 643, in send
  File "requests/adapters.py", line 498, in send
requests.exceptions.ConnectionError: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker-compose", line 3, in <module>
  File "compose/cli/main.py", line 81, in main
  File "compose/cli/main.py", line 200, in perform_command
  File "compose/cli/command.py", line 60, in project_from_options
  File "compose/cli/command.py", line 152, in get_project
  File "compose/cli/docker_client.py", line 41, in get_client
  File "compose/cli/docker_client.py", line 170, in docker_client
  File "docker/api/client.py", line 197, in __init__
  File "docker/api/client.py", line 221, in _retrieve_server_version
docker.errors.DockerException: Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))
[65218] Failed to execute script docker-compose
panic: failed to tear down existing env: failed to run docker-compose to stop test environment: exit status 255

@bai

@bai bai force-pushed the bump-confluent-docker-image-to-6.2.0 branch from 42b0abc to d8db45b Compare September 9, 2021 08:44
@dnwe
Copy link
Collaborator

dnwe commented Sep 9, 2021 •
edited

Looks like the new TestDeleteOffsetsResponse test is a little brittle and can periodically fail. Doesn't look to have been effected by this PR (as you'd expect) so will keep re-running the CI until it passes.

Raised #2012

@dnwe dnwe force-pushed the bump-confluent-docker-image-to-6.2.0 branch from d8db45b to ce4d8e1 Compare September 13, 2021 10:57
@dnwe
chore: upgrade to kafka 2.7.1 branch to cp-6.1.2
2bb5560 
Whilst this isn't a new kafka version, it does bundle a number of fixes
that are probably worth tracking, so bump up to it.

https://docs.confluent.io/platform/6.1.2/release-notes/changelog.html
@dnwe dnwe force-pushed the bump-confluent-docker-image-to-6.2.0 branch from 3f06438 to 2bb5560 Compare September 13, 2021 11:03
@dnwe
fix(test): account for another 2.8.0 InvalidTopic
fc819da 
In Kafka 2.8.0 there is a specific ErrInvalidTopic error response so
allow for that in the functional_client_test.go
@dnwe
Copy link
Collaborator

dnwe commented Sep 13, 2021

woo, we've got this passing now — will merge

@dnwe dnwe merged commit 24950fa into main Sep 13, 2021
@dnwe dnwe deleted the bump-confluent-docker-image-to-6.2.0 branch September 13, 2021 12:32
@dnwe dnwe changed the title Bump confluentPlatformVersion from 6.1.1 to 6.2.0 fix(test): bump confluentPlatformVersion from 6.1.1 to 6.2.0 Sep 13, 2021
@renovate renovate bot mentioned this pull request Oct 4, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Apr 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvuibert vvuibert vvuibert approved these changes

@bai bai Awaiting requested review from bai

@dnwe dnwe Awaiting requested review from dnwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@null-sleep @dnwe @bai @vvuibert