fix: skip over KIP-482 tagged fields #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decoder would error out with "non-empty tagged fields are not supported yet" if it encountered a non-zero length for the tagged fields array. Handle these more graciously (as per the KIP) by skipping over them without deserializing. This fixes an issue with the v3 ApiVersionsResponse on Kafka 2.7.0 and newer which now return the `SupportedFeatures` tagged field on the response (KAFKA-10028). Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
|
❤️ |
This was referenced Jan 19, 2022
This was referenced Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decoder would error out with "non-empty tagged fields are not supported yet" if it encountered a non-zero length for the tagged fields array. Handle these more graciously (as per the KIP) by skipping over them without deserializing.
This fixes an issue with the v3 ApiVersionsResponse on Kafka 2.7.0 and newer which now return the
SupportedFeaturestagged field on the response (KAFKA-10028).