Hardcode integer sizes #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent playing with benchmarks led me down the slippery slop into profiling, where I found this oddity. Calling `binary.Size()` actually involves reflection on the argument which is expensive (of course). There was really no reason not to hardcode these other than vague hand-waving towards portability (really). Saves us about 2.5% of profiled time in the producer benchmarks.
|
nice find! |
|
slight tangent: crc32 calculations account for nearly 40% of the time, so #255 is real and is the lowest-hanging fruit if we ever desperately need more performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent playing with benchmarks led me down the slippery slop into profiling,
where I found this oddity. Calling
binary.Size()actually involves reflectionon the argument which is expensive (of course). There was really no reason not
to hardcode these other than vague hand-waving towards portability (really).
Saves us about 2.5% of profiled time in the producer benchmarks.
@Shopify/kafka