Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Added multi version kafka support #655
Also checkout how different response versions are handled in
I figured out that the BNF for FetchResponse v1 is actually
I think there is an error in the kafka protocol wiki here.
That agrees with https://kafka.apache.org/protocol.html#protocol_messages, so I will update the wiki.
The requests and responses should not store the actual kafka version (0.8.2 or 0.9 or whatever); they should store the actual API version number specific to them (see e.g. what
The kafka version should be stored either as a global (next to
I actually removed version number from
Right now, Kafka version has been made part of the config in this PR. Since our discussion started with this, why not go ahead with it rather than implementing it as global. Test cases would need to be modified though which I have already partially hacked here in an ugly way.