ShopifyAPI::Rest::Base#initialize has a from_hash argument but subclasses override it out

[eni9889]

Issue summary

There's a seeminglyl useful from_hash: argument in ShopifyAPI::Rest::Base#initialize, but it's not usable because all subclasses override #initialize.

# base.rb
def initialize(session: nil, from_hash: nil)
   # elided code

  from_hash&.each do |key, value|
    set_property(key, value)
  end
end

# asset.rb
def initialize(session: ShopifyAPI::Context.active_session)
  super(session: session)
  # elided code
end

Expected behavior

Initialize a ShopifyAPI::Rest::* object with #new(from_hash: my_hash)

Actual behavior

ArgumentError: unknown keyword: :from_hash

Steps to reproduce the problem

Specifications

• shopify_api version: 13.2.0
• Shopify API version used: 2023-10):

[waruboy]

Up! this function is still featured quite prominently in the latest version of doc:

shopify-api-ruby/docs/usage/rest.md

Line 51 in 6c2a45f

| `from_hash` | `Hash` | Default value is `nil`. Sets the resource properties to the values provided from the hash. |