Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShopifyAPI::AssignedFulfillmentOrder.all always returns empty array #992

Closed
johnpash opened this issue Jul 5, 2022 · 3 comments
Closed
Labels

Comments

@johnpash
Copy link

johnpash commented Jul 5, 2022

Issue summary

Write a short description of the issue here ↓
ShopifyAPI::AssignedFulfillmentOrder.all will always return an empty array.

Expected behavior

What do you think should happen?
It should return an array of FulfillmentOrder objects

Actual behavior

What actually happens?
The REST API response of assigned_fulfillment_orders.json look like this:

{
    "fulfillment_orders": [
        {
            "id": 12345,
            "shop_id": 23456,
            "order_id": 34567,
            "assigned_location_id": 45678
            etc.

Base.create_instances_from_response then tries to create objects from the key of the response which is "fulfillment_orders":
https://github.com/Shopify/shopify-api-ruby/blob/main/lib/shopify_api/rest/base.rb#L208

However it's not able to do this because there is a naming mismatch between AssignedFulfillmentOrder and "fulfillment_orders"

Steps to reproduce the problem

  1. setup context as usual
  2. ShopifyAPI::AssignedFulfillmentOrder.all
  3. empty array is returned

Specifications

  • shopify_api version: 10.1.0
  • Shopify API version used (example: 2022-04):
@kaarelss
Copy link
Contributor

This is same issue, just with ShopifyAPI::CustomerAddress - #1018

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the Stale label Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants