Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for token exchanger in Express #630

Open
bakura10 opened this issue Feb 5, 2024 · 2 comments
Open

Add support for token exchanger in Express #630

bakura10 opened this issue Feb 5, 2024 · 2 comments
Labels

Comments

@bakura10
Copy link

bakura10 commented Feb 5, 2024

Overview

Hi,

Shopify recently introduced a new way to exchange tokens (https://shopify.dev/changelog/new-oauth2-token-exchange-api-shopify-managed-install-authorization-flows-available) and reduce flickering and redirect (which has been a common problem for OAuth process).

Unfortunately, while the feature has been added to the SDK (https://github.com/Shopify/shopify-api-js/blob/main/packages/shopify-api/docs/guides/oauth.md#token-exchange) it does not seem to be usable yet in Express app (only Remix app).

Migrating all apps to Remix is not an easy task, so it would be nice to have this supported in the Express app as well to improve the overall user experience for existing merchants.

Thanks.

@matteodepalo
Copy link
Contributor

Hi @bakura10, thank you for opening this issue. This improvement to Express is not in our list of priorities at the moment, but if anybody wants to work on a PR to implement it we'll be happy to review and merge it.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.

@github-actions github-actions bot added the Stale label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants