Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Client still out of date after new codebase #733

Closed
kuipou opened this issue Mar 11, 2022 · 7 comments
Closed

Apollo Client still out of date after new codebase #733

kuipou opened this issue Mar 11, 2022 · 7 comments

Comments

@kuipou
Copy link

kuipou commented Mar 11, 2022

Issue summary

I've just ran a new test app to try out the new code for appnode and I had to run ncu u as there a lot package out of date.
Apollo Client as been updated to use the @apollo/client package instead of boost

Expected behavior

What do you think should happen?

Actual behavior

What actually happens?

Tip: include an error message (in a <details></details> tag) if your issue is related to an error

Steps to reproduce the problem

  1. shopify app create node
  2. npx npx npm-check-updates -u

Reduced test case

the console output:

npx npm-check-updates -u
Need to install the following packages:
  npm-check-updates
Ok to proceed? (y) y
Upgrading /home/kip/site/temp/test2/package.json
[====================] 38/38 100%

 @babel/core                       7.12.10  →    7.17.5     
 @babel/preset-env                ^7.12.11  →  ^7.16.11     
 @babel/register                  ^7.12.10  →   ^7.17.0     
 @shopify/app-bridge-react          ^2.0.6  →   ^2.0.17     
 @shopify/app-bridge-utils          ^2.0.6  →   ^2.0.17     
 @shopify/polaris                   ^6.2.0  →    ^9.2.0     
 dotenv                             ^8.2.0  →   ^16.0.0     
 graphql                           ^14.5.8  →   ^16.3.0     
 koa                               ^2.13.1  →   ^2.13.4     
 koa-router                        ^10.0.0  →   ^10.1.1     
 koa-session                        ^6.1.0  →    ^6.2.0     
 node-fetch                         ^2.6.7  →    ^3.2.2     
 react-apollo                       ^3.1.3  →    ^3.1.5     
 webpack                           ^4.44.1  →   ^5.70.0     
 @babel/plugin-transform-runtime  ^7.12.10  →   ^7.17.0     
 @babel/preset-stage-3              ^7.0.0  →    ^7.8.3     
 babel-jest                         26.6.3  →    27.5.1     
 eslint                             ^8.9.0  →   ^8.10.0     
 eslint-config-next               ^12.0.10  →   ^12.1.0     
 husky                              ^4.3.6  →    ^7.0.4     
 jest                               26.6.3  →    27.5.1     
 lint-staged                       ^10.5.4  →   ^12.3.5     
 nodemon                            ^2.0.7  →   ^2.0.15     
 prettier                            2.2.1  →     2.5.1     
 react-test-renderer               16.14.0  →    17.0.2     

Run npm install to install new versions.

Specifications

  • Browser: none
  • Device: console
  • Operating System: console
@Michael-Gibbons
Copy link

I'm not entirely sure what you're trying to do, if you're referring to the express build, the new build isn't accessible from the cli yet because it isn't merged into master. So you're still seeing the nextjs build as you can see by the package.json using koa

@kuipou
Copy link
Author

kuipou commented Mar 11, 2022

the main branch was fully updated as of 1hours ago and the packages is still out of date

@Michael-Gibbons
Copy link

Are you talking about these dependency updates?
image

if so this does not relate to the express branch, these are automated updates which will not cause version errors and remain backward compatible, so this is still relating to the nextjs codebase.

@kuipou
Copy link
Author

kuipou commented Mar 11, 2022

Anyhow many of the packages relating to nextjs are outdated as evidenced by the ncu and aswell as the Apollo Client package

@Michael-Gibbons
Copy link

Correct which is why the express build exists and will be released soon. There is no point in fixing dependency version errors if a completely new build is going to replace it. If you'd like to still use the nextjs build, feel free to fix the dependencies yourself.

I'd recommend reading some of the other issues and closed PRs to get more context on the situation. For example I myself even opened a PR to fix this. see #700.

@Michael-Gibbons
Copy link

For instructions on using the experimental branch, read the readme or see #725

@teddyhwang
Copy link
Collaborator

thanks for the report - we've since updated the template. please open a new issue if you're still seeing problems with packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants