Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout setting for ActiveResource #225

Closed
ramananbalakrishnan opened this issue Nov 28, 2015 · 0 comments
Closed

Timeout setting for ActiveResource #225

ramananbalakrishnan opened this issue Nov 28, 2015 · 0 comments
Assignees
@alexcoco

Comments

@ramananbalakrishnan
Copy link

Is it possible to make use of the timeout setting available via ActiveResource ?

Adding self.timeout = 5 (or similar value) at lib/shopify_api/resources/base.rb should help.

I understand that ActiveResource is internally based on Net::HTTP, which should have a read_timeout of 60 seconds. However, this change will help to fail-fast rather than have an ActiveResource call wait for a long time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcoco alexcoco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcoco @ramananbalakrishnan @shopifywafflebot