Fix bug with listing classes #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenrose
reviewed
Apr 27, 2017
| fake "collection_listings/1", method: :get, status: 201, body: load_fixture('collection_listing') | ||
| fake "collection_listings//1/product_ids", method: :get, status: 201, body: load_fixture('collection_listing_product_ids') |
There was a problem hiding this comment.
Lol. This bug was actually codified in a test too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listing classes were broken, because they were trying to use the
idfield as a primary key, which doesn't exist for listings. This tells ActiveResource to use the underlying object id as the primary key.This was the reason the URL for fetching the product ids for collections was "/admin/collection_listings//123/product_ids.json" (note the double "//") -- ActiveResource was trying to fill in an id between the slashes, but just ended up rendering an empty string (
nil.to_s)