Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition with redirect.js #1269

Closed
1 task done
jesalerno84 opened this issue May 7, 2021 · 3 comments
Closed
1 task done

Race condition with redirect.js #1269

jesalerno84 opened this issue May 7, 2021 · 3 comments

Comments

@jesalerno84
Copy link
Contributor

jesalerno84 commented May 7, 2021

Description

When running an app with the shopify_app gem installed using rails s a race condition sometimes occurs between asset requests and the request to /auth/shopify. This seems to be because the entire session is being stored inside a cookie with the default dev setup.

Steps to Reproduce

Expected behavior:

The oauth flow should work as normal.

Actual behavior:

The oauth flow fails with a 401.

Reproduces how often:

This seems to happen intermittently.

Browsers

Chrome.

Gem versions

18.0.1.

Additional Information

Security

  • I have redacted any private information from my logs or code snippets.
@jesalerno84 jesalerno84 added the bug label May 7, 2021
@awd
Copy link
Contributor

awd commented Jun 12, 2022

@hannahchen @paulomarg - this issue is linked here: https://github.com/Shopify/shopify_app/blob/main/docs/Troubleshooting.md#my-app-wont-install

Maybe it's time for it to be removed as this issue is stale af.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no activity. It will be closed if no further action occurs in 14 days.

@github-actions github-actions bot added the stale label Sep 23, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

@github-actions github-actions bot closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants