-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11.7 generates ArgumentError (wrong number of arguments (given 2, expected 1)):
#857
Comments
Yes sorry, the new signature is @slucaskim Can you Please update the README.md to update the session#store method signature as well as a note for the change in the new version please? |
@netwire88 To clarify, are you overriding the |
Thanks, the method worked after changing to
|
That is part of #814 It seems like there is an issue with Sprockets 4, We suggest that you pin Sprockets to 3.9 until those issues are fixed |
@slucaskim It sounds like that is what he is doing yes |
Thanks |
I just updated to v11.7 of the gem, but my existing
Shop
object that implementsdef self.store(session)
is now failing with error
ArgumentError (wrong number of arguments (given 2, expected 1)):
. This wasn't happening with v 11.3.0. Anyone else experiencing this?I've also tried changing it to
def self.store(session, *args)
and that didn't work.I was referring to https://github.com/Shopify/shopify_app/blob/master/lib/shopify_app/session/storage_strategies/shop_storage_strategy.rb
The text was updated successfully, but these errors were encountered: