Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find useless shim definitions from payload #645

Closed
Morriar opened this issue Dec 3, 2021 · 2 comments
Closed

Find useless shim definitions from payload #645

Morriar opened this issue Dec 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Morriar
Copy link
Collaborator

Morriar commented Dec 3, 2021

When we clean shims we do not consider Sorbet's payload RBIs.

This means that when a definition in our shims becomes useless because it's been upstreamed, we never clean it.

We should use Sorbet's symbol table to bootstrap the index and remove the outdated definitions.

Problem: how to know if the symbol in the table is actually attached to a signature? Maybe we should add an option to Sorbet so it can dump its internal RBIs?

@Morriar Morriar added the enhancement New feature or request label Dec 3, 2021
@Morriar Morriar self-assigned this Dec 3, 2021
@Morriar Morriar changed the title Find useless definition from payload Find useless shim definitions from payload Dec 3, 2021
@Morriar Morriar added this to the Tapioca 1.0 milestone Feb 10, 2022
@Morriar
Copy link
Collaborator Author

Morriar commented Mar 25, 2022

Pushed the first part so we can extract the content of the payload from the Sorbet version used: sorbet/sorbet#5504.

@Morriar
Copy link
Collaborator Author

Morriar commented Apr 13, 2022

Done in #879 🎉

@Morriar Morriar closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant