Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Validate if we need to ignore UnusuedSnippet with dynamic render #332

Closed
macournoyer opened this issue Jun 29, 2021 · 1 comment
Closed

Validate if we need to ignore UnusuedSnippet with dynamic render #332

macournoyer opened this issue Jun 29, 2021 · 1 comment
Labels
linter Check related issues
Projects
Developer experience

Comments

@macournoyer
Copy link
Contributor

We ignore UnusuedSnippet check as soon as a dynamic render is used: {% render block %}

https://github.com/Shopify/theme-check/blob/master/lib/theme_check/checks/unused_snippet.rb#L20

Maybe this is not needed for render? Need to revisit this.
@macournoyer macournoyer self-assigned this Jun 29, 2021
@charlespwd charlespwd added the linter Check related issues label Jul 15, 2021
@charlespwd charlespwd added this to Triage in Developer experience Mar 2, 2022
@lukeh-shopify
Copy link
Contributor

Closing as Ruby implementation specific

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
linter Check related issues
Projects
No open projects
Developer experience
Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@macournoyer @charlespwd @lukeh-shopify