-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'endcomment' is not a valid delimiter #422
Comments
Looks like a liquid bug (or feature?). I'll investigate. |
Oh wow. It is an old issue no one fixed: Shopify/liquid#936. There's been two PRs that never got merged because of failing tests. Might be worth revisiting. Commenting out if branches is a pretty darn valid use case. |
Any solution for this issue? I too would like to be able to comment {% if %} tags without having to add an extraneous {% endif %} |
Also following this up to see if it has been fixed, or is going to be? |
It comes in conflict with the ability to nest comments. A lot of folks (support in particular) comment out large sections of code by adding {% comment %}
We support nested comments.
{% comment %}
this explains the block of code
{% endcomment %}
{% for el in col %}
...
{% endcomment %}
{% endcomment %} There's a way to make this work but it would require a lot of work on the parser, and it's hard to prioritize the amount of work required here against everything else we have to work on. It might happen, but—as far as I know—this isn't on any team's radar. |
I'm here from googling exactly the same issue. Changing from Explicitly stating it here for future searchers. It didn't occur to me until I saw Zebsola's comment. |
Commenting conditionals throws the error 'endcomment' is not a valid delimiter, use endif. The error is also logged in the terminal while
shopify theme serve
.The text was updated successfully, but these errors were encountered: