Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warning/errors when an custom element isn't closed with the proper tag #640

Open
ludoboludo opened this issue Sep 21, 2022 · 0 comments

Comments

@ludoboludo
Copy link

Is your feature request related to a problem? Please describe.

We had an instance in Dawn where theme check didn't pick up on an custom element being closed with the wrong tag.

Here is the scenario:

<slideshow-component>
  ...
</slider-component>

Describe the solution you'd like

I wonder if there could be a check around custom elements to make sure the closing tag is using the same name ?

Describe alternatives you've considered

No alternatives, just making sure we review our code for those kind of mistakes.

Additional context

PR that fixed this on Dawn: Shopify/dawn#1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant