UnusedSnippet selecting snippets that are being used

[saiichihashimoto]

Describe the bug
We had UnusedSnippet on with autofix and files that were actually being used were being deleted. We could turn off autofix, but it would then still have false positives and report an error. They use the {% render 'snippet' %} syntax.

Expected
UnusedSnippet should not report on snippets that are actually used.

Actual
UnusedSnippet does report on snippets that are used.

Debugging information

• Mac Apple M2, but also in Github Actions
• Version: 1.15.0

[lukeh-shopify]

Hi @saiichihashimoto, thanks for the report. Are you able to switch to the more maintained non Ruby version (shopify/theme-check-action@v2) of the Github Action and confirm this is still an issue? The ruby version is now deprecated.

If you are having trouble with the latest version of the Github Action, please raise an issue over in https://github.com/Shopify/theme-check-action

[saiichihashimoto]

Nothing in this repo mentions that this is deprecated, correct me if I'm wrong. Also, are you saying that we've replaced the local cli with a github action only? Very confusing where I'm supposed to install this from or file this issue for it to just get closed and not moved to the correct repo... 😭

[lukeh-shopify]

Nothing in this repo mentions that this is deprecated, correct me if I'm wrong. Also, are you saying that we've replaced the local cli with a github action only? Very confusing where I'm supposed to install this from or file this issue for it to just get closed and not moved to the correct repo... 😭

Hey @saiichihashimoto, sorry for not being very clear. I'm in the process of deprecating the theme-check repository at the moment, as there is no current support for it.

It looks like I incorrectly assumed that you were using the Github action. You are still able to use Shopify CLI to run theme checks. I'm going to transfer this issue to the Shopify CLI, and are you able to confirm that you are still having the same issue with the latest version of the CLI?