Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing editor.action.commentLine command #258

Open
AbdielBiza opened this issue Dec 12, 2023 · 0 comments
Open

Missing editor.action.commentLine command #258

AbdielBiza opened this issue Dec 12, 2023 · 0 comments
Labels
Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future

Comments

@AbdielBiza
Copy link

Describe the bug

I am writing to report a bug with the extension. It seems that the extension does not declare a commentLine property in the package.json /language-configuration.ts, ( suspected line ) , which prevents the line comment shortcut (Ctrl+/) from working properly. This is a very useful feature and I would appreciate it if you could add it to the extension. Thank you.

Source

N/A

Expected behaviour

Line comment and block comment should have different keybindings

Actual behaviour

Only commentBlock is defined, so both shortcuts insert block comment, even inside {% liquid %} tag

Debugging information

  • Windows
  • OS Version : 23H2
  • Shopify CLI version: 3.52.0

Additional context
Line comment added to Liquid

@mgmanzella mgmanzella added Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working open for contributions theme bugs that won't be prioritized in the near future
Projects
None yet
Development

No branches or pull requests

2 participants