Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch from master to main #489

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

joeytepp
Copy link

For consistency with other projects, renaming the trunk branch from master to main. Once the documentation is updated I will make this change for the GH repo as well.

@joeytepp joeytepp requested a review from a team April 13, 2023 14:47
Copy link

@etiennemartin etiennemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not wait until the default branch is changed? Looks like it's still master.

@etiennemartin etiennemartin requested a review from a team April 14, 2023 15:30
@joeytepp
Copy link
Author

@etiennemartin yes I was not planning to merge this until the trunk branch was formally changed, but didn't wanted to ship this shortly after the change

Copy link

@etiennemartin etiennemartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And the branch was updated! should be good to go!

@joeytepp joeytepp merged commit cb86b30 into master Apr 20, 2023
@joeytepp joeytepp deleted the master-to-main branch April 20, 2023 15:25
@joeytepp joeytepp restored the master-to-main branch April 20, 2023 15:26
@miry miry changed the title Rename trunk branch to main Rename default branch from master to main Apr 24, 2023
- [toxiproxy-java](https://github.com/trekawek/toxiproxy-java)
- [toxiproxy-haskell](https://github.com/jpittis/toxiproxy-haskell)
- [toxiproxy-rust](https://github.com/itarato/toxiproxy_rust)
- [toxiproxy-elixir](https://github.com/Jcambass/toxiproxy_ex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those markdown changes are not related to that PR.

$ sudo service toxiproxy start
wget -O toxiproxy-2.1.4.deb https://github.com/Shopify/toxiproxy/releases/download/v2.1.4/toxiproxy_2.1.4_amd64.deb
sudo dpkg -i toxiproxy-2.1.4.deb
sudo service toxiproxy start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those markdown changes are not related to that PR.

@miry
Copy link
Contributor

miry commented Apr 24, 2023

I found that the PR did more that expected from the Title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants