-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename default branch from master
to main
#489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not wait until the default branch is changed? Looks like it's still master
.
@etiennemartin yes I was not planning to merge this until the trunk branch was formally changed, but didn't wanted to ship this shortly after the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! And the branch was updated! should be good to go!
main
master
to main
- [toxiproxy-java](https://github.com/trekawek/toxiproxy-java) | ||
- [toxiproxy-haskell](https://github.com/jpittis/toxiproxy-haskell) | ||
- [toxiproxy-rust](https://github.com/itarato/toxiproxy_rust) | ||
- [toxiproxy-elixir](https://github.com/Jcambass/toxiproxy_ex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those markdown changes are not related to that PR.
$ sudo service toxiproxy start | ||
wget -O toxiproxy-2.1.4.deb https://github.com/Shopify/toxiproxy/releases/download/v2.1.4/toxiproxy_2.1.4_amd64.deb | ||
sudo dpkg -i toxiproxy-2.1.4.deb | ||
sudo service toxiproxy start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those markdown changes are not related to that PR.
I found that the PR did more that expected from the Title. |
For consistency with other projects, renaming the trunk branch from
master
tomain
. Once the documentation is updated I will make this change for the GH repo as well.