Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Page.refresh #73

Open
qq99 opened this issue Feb 12, 2015 · 4 comments
Open

Refactor Page.refresh #73

qq99 opened this issue Feb 12, 2015 · 4 comments
Labels
enhancement

Comments

@qq99
Copy link
Contributor

qq99 commented Feb 12, 2015 

Page.refresh
  response: xhr
  onlyKeys: [...]

vs

Page.refresh
  onlyKeys: [...]

Latter does an extra GET, the former uses the response of an XHR, but they're both named refresh. The former should be named replace or something
@maartenvg maartenvg mentioned this issue Feb 19, 2015
Merged
@qq99
Copy link
Contributor Author

qq99 commented Apr 1, 2015

@maartenvg I think your PR addressed this issue?

@maartenvg
Copy link
Contributor

Not really? It is still called refresh, despite taking different inputs.

@qq99
Copy link
Contributor Author

qq99 commented Apr 1, 2015

Gotcha 👍 thanks

@marutypes
Copy link
Contributor

This makes a lot of sense, I'm a little worried that our existing uses in the admin might call Page.refresh with an xhr directly though. I'll take a look. I'd be worried about breaking the api though (especially as long as we have the weird doppelganger version of Remote in our core codebase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qq99 @maartenvg @marutypes