Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to App Bridge 2 #41

Closed
asecondwill opened this issue Jun 29, 2021 · 7 comments
Closed

Update to App Bridge 2 #41

asecondwill opened this issue Jun 29, 2021 · 7 comments

Comments

@asecondwill
Copy link

This is a requirement now to pass the app review.

@tdonia
Copy link
Contributor

tdonia commented Jul 1, 2021

can you share what local changes you've made to the app? i've just tried bumping the shopify_app gem in a clean clone, and it seems to work without issue. here's the branch: https://github.com/Shopify/turbolinks-jwt-sample-app/compare/shopify_app-18-update

@oliwoodsuk
Copy link

oliwoodsuk commented Jul 10, 2021

Do you have this line of code in your theme: <script src="https://unpkg.com/@shopify/app-bridge@1"></script> ?
If so, I think you'll have to bump it up to @2

@tdonia
Copy link
Contributor

tdonia commented Jul 12, 2021

my branch uses the unversioned/latest unpkg link unchanged from the main branch: https://github.com/Shopify/turbolinks-jwt-sample-app/blob/shopify_app-18-update/app/views/layouts/embedded_app.html.erb#L27 which resolves to 2.0.3 and seems to work for me without issue?

@netwire88
Copy link

Should we continue to use

  window.app = createApp({
    apiKey: data.apiKey,
    shopOrigin: data.shopOrigin,
  });

in shopify_app.js? It seems like that's working instead of host.

@kirillplatonov
Copy link

Here's an example app with JWT integration and AppBridge 2: https://github.com/kirillplatonov/shopify-hotwire-sample

@tdonia
Copy link
Contributor

tdonia commented Aug 17, 2021

@netwire88 -- sorry for the delay. host should be used instead of shopOrigin -- as in @kirillplatonov's example or in the updated shopify_app.js example in this repo. now that #45 has been merged I'm going to close this issue.

@tdonia tdonia closed this as completed Aug 17, 2021
@kirillplatonov
Copy link

@tdonia can we also merge App Bridge 2 related PR in shopify_app gem?
Shopify/shopify_app#1277

And once it merge I could also open PR with this change: kirillplatonov/shopify_app@b46ccc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants