[ESLint-plugin] Add eslint 'graphql/required-fields' rule for 'id' field #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
id
field to graphl/required-fields eslint rule. This rule has been added in Web (https://github.com/Shopify/web/pull/27464) and Plus-Web (https://github.com/Shopify/plus-web/pull/4203) and should be a Shopify-wide rule, given the advantages of always requiring the id field in graphql queries.A full analysis of the reasoning for the rule, as well as the advantage/risk analysis can be found here.
Changelogs
New rules I enabled
Type of change
Checklist