Add "prev_ruby_yjit" config to compare yjit 3.3 with yjit dev #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very happy to see this in action, and it's already useful to spot benchmarks where we might have regressions. One thing I would like to change is to remove the bars at 1.0 and add a horizontal line at 1.0 instead. It will be more space-efficient that way. Can be another PR if you prefer. |
|
Nitpick but, the green box with YJIT should say YJIT 3.4 or YJIT 3.4dev |
maximecb
approved these changes
May 11, 2024
|
I updated the legend: I'd like to merge this as is to start getting the data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not pretty, but functional:
This installs ruby 3.3.1 via ruby-build and adds it to the default list of configs that run the benchmarks.