Show build configuration on home page header #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwstauner
commented
Jul 31, 2024
rwstauner
commented
- Don't use -j with install
- Collect CC_VERSION_MESSAGE
- Make commit hash length consistent with RUBY_VERSION
- Add build config to front page header
maximecb
reviewed
Jul 31, 2024
| @@ -62,7 +62,8 @@ def clone_ruby_repo_with(path:, git_url:, git_branch:, config_opts:, config_env: | |||
| check_call("make clean") | |||
| end | |||
|
|
|||
| check_call("make -j16 install") | |||
| check_call("make -j16") | |||
| check_call("make install") | |||
There was a problem hiding this comment.
Not that important but you can do make -j && make install
|
I notice that the templates are under |
|
No, it's just part of the way I merged the files in from the other repo into a subdirectory of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.