This repository has been archived by the owner on Oct 3, 2022. It is now read-only.
[WIP: Do merge] Improve how Preferences are handled #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it look better with reasonably sized fonts
Revamp settings 2 accepted
+ Add dependency:
- kotlin
- preferences
- rx preferences
+ Add files
- PreferenceKeys
- PreferencesHelper
+ Add dependency:
- kotlin
- preferences
- rx preferences
+ Add files
- PreferenceKeys
- PreferencesHelper
|
What is the main issue with preferences? |
|
Preferences from throughout project are in SettingsController, this aims to bring all of them under PrefrencesHelper so that SettingsController only has to mange things that are in settings: eg. Consider togglePause() in SettingsController it is there to manage an option that is not even in the settings. At the same time, DownloadFragment has to import SettingsController to manage the pause button. |
|
I see, i did make a mess of those underlying functions |
|
My soul cried when I saw isReaderLightMode() it's still crying but I'm trying to fix it. |
|
wait what was so horrible about it?! |
+ Add dependency:
- kotlin
- preferences
- rx preferences
+ Add files
- PreferenceKeys
- PreferencesHelper
Move all Settings Fragments one directory up
|
Oof I shouldn't have rebased it. |
added 8 commits
July 25, 2019 15:11
Update build.gradle, SettingsController.java, and 11 more files...
Update build.gradle and SettingsFragment.kt
Inspired by tachiyomi
+ Additionally all fragments in main are loaded lazily
hXtreme
commented
Jul 26, 2019
app/src/main/java/com/github/doomsdayrs/apps/shosetsu/backend/preference/PreferenceKeys.kt
Show resolved
Hide resolved
hXtreme
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor out all preferences to preference helper.
Initial Commit for Preferences
Add dependency:
Add files