Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what the policy is on using external modules and
entryName
handling, so I make a Draft PR.Use the GatherCandidatesArguments from ddc.vim 2e4bf03
This resolves
TS2416 [ERROR]: Property 'gatherCandidates' in type 'Source' is not assignable to the same property in base type 'BaseSource'.
error.Use the CompletionItem from vscode_languageserver_types 98372d6
This resolves some
(no-explicit-any)
problems from deno lint.I did not know how to handle
entryName
, and I did not findentryName
in Language Server Protocol Specification.If
entryName
handling is needed, we cannot use vscode_languageserver_types as is.Use the equal from equal for checking the objects are equal c2d73fd
From https://basarat.gitbook.io/typescript/recap/equality#structural-equality
textEdit.range.{start,end} are Position,
so I think we should not use ==/===.