Add a benchmark for enqueueing data #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us measure how fast jobs can be enqueued (about 0.8ms per run). Updates a bunch of *testing.T to instead take the testing.TB interface, so we can pass a *testing.B and have things still work. Adds a Make target for running benchmarks. Run the benchmarks in Travis CI, and specify the go_import_path so forks still build okay.
caseycrites
reviewed
Dec 19, 2016
| @@ -63,7 +63,7 @@ func RandomId(prefix string) types.PrefixUUID { | |||
| } | |||
| } | |||
|
|
|||
| func CreateJob(t *testing.T, j models.Job) models.Job { | |||
| func CreateJob(t testing.TB, j models.Job) models.Job { | |||
There was a problem hiding this comment.
How come testing.TB isn't passed by reference?
|
Interfaces are always pointers already, so a *testing.TB would be like a
**testing.T. If it's a concrete type you generally need to pass the pointer
to satisfy the interface. Hope that makes sense.
…On Mon, Dec 19, 2016 at 11:33 Casey W Crites ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/factory/factory.go
<#8 (review)>:
> @@ -63,7 +63,7 @@ func RandomId(prefix string) types.PrefixUUID {
}
}
-func CreateJob(t *testing.T, j models.Job) models.Job {
+func CreateJob(t testing.TB, j models.Job) models.Job {
How come testing.TB isn't passed by reference?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOSIwk9nOR7fANpxKoMvm75Z7nqoVlVks5rJtwDgaJpZM4LNLJb>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us measure how fast jobs can be enqueued (about 0.8ms per run).
Updates a bunch of *testing.T to instead take the testing.TB interface, so
we can pass a *testing.B and have things still work. Adds a Make target for
running benchmarks. Run the benchmarks in Travis CI, and specify the
go_import_path so forks still build okay.