Allow text or html or both, but not neither #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for the PR, i'll version a new npm release hopefully tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally made a PR for this change against jdelibas' fork, seeing as that one has a Dockerfile. But there's been no response there, and it seems you've made changes in the last few months, so I was hoping you might take a look at this 馃檪
Details copied over from the other PR:
Currently aws-ses-local requires that both html and text bodies be present.
If you try manually sending a request to the real SES, you'll find that it does allow you to omit one of them (as long as you have the other).
This PR makes it so that requests succeed as long as at least one of the two has been given.