Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SendRawEmail #11

Merged
merged 3 commits into from Nov 20, 2017
Merged

Implement SendRawEmail #11

merged 3 commits into from Nov 20, 2017

Conversation

camjackson
Copy link
Contributor

@camjackson camjackson commented Oct 28, 2017

Resolves #5.

Changes:

  • Implements the SendRawEmail function, including base64 decoding of the raw message
  • Responds with an error to unsupported actions. Previously it would just never respond, leaving the client to eventually time out
  • Wrote unit tests for new code
  • Upgraded node version on travis from 5.6 to 5.10, in order to use Buffer.from
  • Chose the sushi emoji 🍣 to represent 'raw' email requests 😁
  • Tested it manually and it works!

Notes for reviewer:
The diff, when viewed all at once, looks a bit scary because:

  • The first commit extracts a bunch of code into a separate module
  • The second commit contains a big de-dentation which makes it look like I changed a bunch of lines when really it's just whitespace

So to make the review easier, I recommend:

  • Reviewing one commit at a time rather than all at once; and
  • Put ?w=1 onto the end of the github URL, which makes it hide whitespace changes so you can see what actually changed

Happy to make changes wherever needed 🙂

@coveralls
Copy link

Coverage Status

Coverage increased (+4.03%) to 92.126% when pulling be6a4a7 on camjackson:sendrawemail into 9c91a41 on Si1kIfY:master.

@camjackson
Copy link
Contributor Author

@Si1kIfY any chance you could take a look at this? I've been using it myself and it works well.

@csi-lk csi-lk merged commit 3402882 into csi-lk:master Nov 20, 2017
@csi-lk
Copy link
Owner

csi-lk commented Nov 20, 2017

Merged and released, thanks mate

@camjackson camjackson deleted the sendrawemail branch November 20, 2017 12:58
@camjackson
Copy link
Contributor Author

No worries, thanks for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants