Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: refreshing page inside a bucket causes 404 #1026

Closed
artur9010 opened this issue Mar 4, 2024 · 1 comment · Fixed by SiaFoundation/web#537
Closed

ui: refreshing page inside a bucket causes 404 #1026

artur9010 opened this issue Mar 4, 2024 · 1 comment · Fixed by SiaFoundation/web#537
Assignees
Labels
bug Something isn't working

Comments

@artur9010
Copy link

Current Behavior

image

Expected Behavior

Load file list

Steps to Reproduce

  1. Go to bucket list
  2. Go into any bucket
  3. Try to refresh page (F5)

Version

de431b6

What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?

Ubuntu, Kubernetes (https://github.com/artur9010/charts/tree/master/renterd)

Autopilot Config

x

Bus Config

x

Contract Set Contracts

x

Anything else?

No response

@artur9010 artur9010 added the bug Something isn't working label Mar 4, 2024
@artur9010 artur9010 changed the title ui: refreshing file list inside a bucket causes 404 ui: refreshing page inside a bucket causes 404 Mar 4, 2024
@alexfreska
Copy link
Member

This issue is caused by the new route pattern for buckets and files:

/buckets/bucket_name/files/path/to/directory

which generates an html entry point like:

/buckets/[bucket]/files/[[...path]].html

The special nextjsRouter static http.Handler does not support the param + catch all combo: https://github.com/SiaFoundation/web/blob/main/ui/ui.go

It needs to work for this sort of case: SiaFoundation/web@c8795eb#diff-797a8ca0587dda82ce75e0a8c8a5b08207d68ca17ee1dfbe1b4d33e6ba0af258R205-R206

@n8maninger is this is a difficult change? I am not familiar with that magical code 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants