feat: add method to query the current covenant #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `getCovenant()` method to return the name of the current covenant, and a new `isCovenant()` method to check if the given covenant matches the current one. Fire a new Ovale event `Ovale_CovenantChosen` after the module has reacted to `COVENANT_CHOSEN` and can return the correct information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
getCovenant()method to return the name of thecurrent covenant, and a new
isCovenant()method to check if thegiven covenant matches the current one.
Fire a new Ovale event
Ovale_CovenantChosenafter the modulehas reacted to
COVENANT_CHOSENand can return the correctinformation.