Remove unnecessary use of "tostring". #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to call "tostring" after we've checked that it's already a string. Simply use "as string" to help with type assertion.
Sidoine
requested changes
Dec 14, 2020
src/states/covenant.ts
Outdated
| @@ -86,7 +86,7 @@ export class Covenant { | |||
| if (isNumber(covenant)) { | |||
| return ReturnBoolean(this.covenantId === covenant); | |||
| } else if (isString(covenant)) { | |||
| const name = tostring(covenant); | |||
| const name = covenant as string; | |||
There was a problem hiding this comment.
Hmm, when I originally submitted the changes to covenant.ts, the check bot on GitHub complained about errors during the compile phase, but when I run them locally now, the errors aren't there. I will change this a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to call "tostring" after we've checked that it's
already a string. Simply use "as string" to help with type
assertion.
This commit is a small optimization, but is mostly to test that
my development environment works correctly to use nodejs
to turn TypeScript into Lua correctly.