Spells are usable only if they meet all of their power requirements #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Blizzard API function GetPowerRegen() can return very small numbers when the actual regeneration rate is zero. Treat very small numbers to be equal to zero in getPowerRateAt(). Also, add some type signatures to getPowerRateAt() while we are here.
Modify getTimeToPowerStateAt() to check every power type if one is not specified, instead of just the primary resource type. Fixes issue Sidoine#737.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits will cause a spell to not be suggested if their
power requirements cannot be met simply by waiting, e.g., chi,
holypower, combopoints, runicpower, etc.
This will cause most scripts to correctly fall through to other
spells which can be cast instead of suggesting a spell that is
waiting on resources.