Fix script translations of totem pets #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every spell or item that summons minions has those minions treated as totems by the game. Their information can be retrieved via the Blizzard API function GetTotemInfo(slot). Treat every class as a totem-capable class and track their totem states appropriately through game events.
Try to pattern-match for EmitOperandSpecial() before falling through to the rest of the pet operand logic. This allows for checking for specific problematic actions that need to be handled specially before doing the usual pet operand logic. Verified to emit the same scripts as before this change.
Blood and frost death knights summon a ghoul with Raise Dead that the game treats as a totem, so use TotemPresent() and TotemRemaining() to translate "active" and "remains". Unholy death knights summon a true pet ghoul, but also have three abilities that summon minions that are not true pets: Army of the Dead, Apocalypse, and Summon Gargoyle. Army of the Dead and Apocalypse ghouls are neither pets nor totems, so translate pet.*.active by comparing the remaining spell cooldown with the cooldown duration. Summon Gargoyle functions as a totem, so use TotemPresent() and TotemRemaining() to translate "active" and "remains".
Remove Niuzao and Xuen, which are actual pets. Add Chi-Ji and Yulon for mistweavers which are totems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullup does the following:
EmitOperandSpecial()before falling through to the rest of the pet operand logic. This allows forhandling of special cases sooner in the flow.
This fixes issue #761.