fix(druid): many fixes and improvements to feral script #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following buffs work with feral snapshotting: * Tiger's Fury buffs Rake, Rip, Thrash, and Moonfire. * Bloodtalons buffs Rip. * Improved Rake (from stealth) buffs Rake. Add the corresponding SpellDamageBuff() lines to the spell definitions so that the *Multiplier() conditions will return the correct values instead of the default of 1.
Balance specialization or Balance Affinity is required for casting Moonkin Form, Starfire, Starsurge, Sunfire, or Typhoon. Guardian specialization or Guardian Affinity is required for casting Frenzied Regeneration or Incapacitating Roar. Feral specialization or Feral Affinity is required for Maim, Rake, Rip, Main, or Swipe.
GetBaseDuration() is meant to return the duration of an aura if it was applied by a specific spellcast or in the current state. When called with no spellcast argument, it was assuming zero combopoints and not correctly extending the duration via the property "add_duration_combopoints". In this case, grab the number of combopoints from the current state instead. Since GetBaseDuration() now uses state, adjust it to take atTime as an optional parameter to figure out which state to use.
The return value of TickTimeRemaining() isn't a constant, since it varies over a time interval. Use the correct (value, origin, time) triplet instead.
This is extremely basic support for an aura that is applied at two different durations by two different spells. The spell identified with "half_duration=spellId" in SpellInfo() causes the base duration calculation to be halved.
Add a basic implementation of ticksGainedOnRefresh() to replace the incorrect "ReturnConstant(0)".
Add a new section to EmitOperandSpecial() to parse and translate "druid.<spell>.ticks_gained_on_refresh", with a special case for primal_wrath.
The current SimC feral druid profile used as a basis for the default feral Ovale script sometimes suggest Primal Wrath on single target. Fix this by emitting an extra condition to check for more than one enemy when suggesting the Primal Wrath action.
Regenerate feral druid scripts for ticks_gained_on_refresh and primal_wrath changes to simulationcraft/emiter.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pullup makes many fixes to the feral druid spell definitions,
adds an implementation for
TicksGainedOnRefresh()used by thedefault feral scripts, and fixes the importer to emit the correct
script code for
druid.<spell>.ticks_gained_on_refresh.The feral script seems usable now with some light testing against
a target dummy on a level 52 feral druid.
This fixes issue #777.