fix: properly check for known spells in InUsableSpell() #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert 86439eb and fix the underlying problem in a different way. That commit used the WoW IsUsableSpell() API function to determine whether a spell is known, but that returns false if the spell is genuinely not usable due to either cooldown or power requirements. Fix this in a better way by teaching SpellBook.ts:IsKnownSpell() to check for a spell being known to the player even if it's not in the spellbook by using the WoW IsSpellKnown() API function. While here, adjust IsUsableSpell() so that there is only a single exit point from the function to make the profiler stats work correctly.
Sidoine
requested changes
Jan 18, 2021
The WoW API function IsUsableSpell() can just directly take a spell ID as a valid parameter now, so remove the special lookup of a spell by (index, bookType) or by name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 86439eb and fix the
underlying problem in a different way. That commit used the WoW
IsUsableSpell() API function to determine whether a spell is known,
but that returns false if the spell is genuinely not usable due to
either cooldown or power requirements. Fix this in a better way by
teaching SpellBook.ts:IsKnownSpell() to check for a spell being
known to the player even if it's not in the spellbook by using the
WoW IsSpellKnown() API function.
While here, adjust IsUsableSpell() so that there is only a single
exit point from the function to make the profiler stats work
correctly.