Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monk): don't suggest spamming SEF: Fixate when SEF is active #824

Merged
merged 2 commits into from Jan 24, 2021
Merged

fix(monk): don't suggest spamming SEF: Fixate when SEF is active #824

merged 2 commits into from Jan 24, 2021

Conversation

johnnylam88
Copy link
Contributor

No description provided.

@johnnylam88
fix(simulationcraft): ignore storm_earth_and_fire_fixate for monks
8b66aca 
The Storm, Earth, and Fire: Fixate spell can be cast off-GCD at any
time, but there is no way to tell if the copies are actually
fixated on a single target or not. Just ignore the spell action so
that the script does not ask the player to keep spamming Fixate.
@johnnylam88
fix(monk): windwalker scripts should not use storm_earth_and_fire_fixate
6ccef25
@Hemario
Copy link
Contributor

Hemario commented Jan 23, 2021

Wouldn't it have been easier to make a SpellRequire(storm_earth_and_fire_fixate unusable set=1) definition in monk_spells.ts?

@Sidoine Sidoine merged commit 31936ba into Sidoine:master Jan 24, 2021
@johnnylam88 johnnylam88 deleted the fix/ww-monk-sef-fixate branch January 26, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnnylam88 @Hemario @Sidoine