New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define constant in many files #5

Open

cchauche opened this issue Jul 7, 2021 · 0 comments

cchauche commented Jul 7, 2021

products/server/controllers/retrieveProductStyles.js

Line 5 in 35408ad

const DEFAULT_EXPIRATION = 3600;

You are defining the same constant in multiple files, I wonder if this would be better placed in a configuration file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment