Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$timeout and $version variables are not exist on unlabel function. #38

Closed
yuchimiri-zz opened this issue Sep 26, 2016 · 1 comment
Closed

$timeout and $version variables are not exist on unlabel function. #38

yuchimiri-zz opened this issue Sep 26, 2016 · 1 comment

Comments

@yuchimiri-zz
Copy link
Contributor

Hi, I'm using this library and found a bug.

unlabel() function referred a non-existing variable.
https://github.com/SiftScience/sift-php/blob/master/lib/SiftClient.php#L216

$timeout and $version variables should be $opts['timeout'] and $opts['version'].
Thanks.
@yuchimiri-zz
Copy link
Contributor Author

sent a PR: #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuchimiri-zz