You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#62 will expose errors in SiftResponse. I agree that we should do more to expose those exceptions, even letting them bubble up, but looking through the code paths, I'm trying to see where they could happen under normal error conditions (network failures, invalid request data, bad json response). curl errors are reported through error codes, the json parsers return null, and SiftResponse marks errors with isOk(), so you shouldn't be seeing errors.
We are interested in using this library but all API calls swallow and hide Exceptions which prevents us from knowing what error occurred.
Example: https://github.com/SiftScience/sift-php/blob/master/lib/SiftClient.php#L105-L114:
In other words, can the try/catch within each API method be removed? Example:
If so, then library adopters can be in charge of handling exceptions as per their unique requirements:
Unfortunately, we must know when and why exceptions occur so cannot use this library for that simple reason.
The text was updated successfully, but these errors were encountered: