Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Province Name Changing Errors #155

Open
rderekp opened this issue Jan 3, 2019 · 0 comments
Open

Province Name Changing Errors #155

rderekp opened this issue Jan 3, 2019 · 0 comments

Comments

@rderekp
Copy link

rderekp commented Jan 3, 2019

I'm going to figure out how to do a pull request one of these days.

But, on line 2569, in the part about organizing Tanzania, there is this:

  	1850 = { change_province_name = "Tabora" }

But province 1850 is a province in Eritrea. I think this should be province 2043. (Which is already called Tabora, but that happens sometimes with the existing code.)

EDIT: I found some more similar duplications.

In decisions/SAF.txt and events/BritishDominions.txt, province 2110 can have its name changed to Hoedspruit. But in events/BoerWar.txt and decisions/BoerWar.txt, it's province 3273 which gets the name change to Hoedspruit. To be honest, I am not exactly sure which is correct, and maybe the creator of the SAF mod knows?

Also, in decisions/FlavourMod_France_Colonial.txt, both provinces 2515 and 2571 are changed to the name "Jeanne" for French New Zealand.

@rderekp rderekp changed the title Typo in New Colonies.txt Province Name Changing Errors Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant